GH-43440: [R] Unable to filter a factor column with %in%#43446
Merged
nealrichardson merged 1 commit intoapache:mainfrom Sep 22, 2024
Merged
GH-43440: [R] Unable to filter a factor column with %in%#43446nealrichardson merged 1 commit intoapache:mainfrom
nealrichardson merged 1 commit intoapache:mainfrom
Conversation
|
|
nealrichardson
commented
Jul 27, 2024
| value_set <- cast_or_parse(value_set, x$type()), | ||
| silent = TRUE | ||
| value_set <- cast_or_parse(value_set, x_type), | ||
| silent = !getOption("arrow.debug", FALSE) |
Member
Author
There was a problem hiding this comment.
I added this while I was in here because one of my initial thoughts was that we were trying to cast to dictionary and it was failing, but the error was being swallowed. It turned out that it was in fact casting to dictionary but that wasn't what was needed.
jonkeane
approved these changes
Sep 21, 2024
Member
jonkeane
left a comment
There was a problem hiding this comment.
Thanks for this! I agree with keeping this limited here and then expanding later if we see if it's a bigger issue.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 81b94dc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #43440
What changes are included in this PR?
The binding for
%in%sends the DictionaryType'svalue_typetocast_or_parse(). It's possible that it would be better to handle this incast_or_parse(), but it is used in lots of places and I wasn't sure that was correct everywhere. We could certainly find out, but that's a bigger testing exercise than I wanted to take on this afternoon.Are these changes tested?
Yes.
Are there any user-facing changes?
The bug is fixed.
%in%#43440