GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+#43395
GH-43394: [Java][Benchmarking] Fix Java benchmarks for Java 17+#43395danepitkin merged 2 commits intoapache:mainfrom
Conversation
|
|
|
@ursabot please benchmark lang=Java |
|
Benchmark runs are scheduled for commit 3b8b942. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
|
Benchmark run is successful: https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-m5-4xlarge-us-east-2/builds/5025 |
vibhatha
left a comment
There was a problem hiding this comment.
Thanks @danepitkin, PR LGTM.
|
@danepitkin shall we run the crossbows as well? |
|
@github-actions crossbow submit -g java |
|
Thanks @vibhatha! |
|
Revision: 3b8b942 Submitted crossbow builds: ursacomputing/crossbow @ actions-4f8795faaf
|
|
Thanks for your patience. Conbench analyzed the 2 benchmarking runs that have been run so far on PR commit 3b8b942. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a49dbcc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Now that Arrow Java has moved from Java 8 -> Java 11, we need to add
--add-openswhen running Java.What changes are included in this PR?
--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMEDto_JAVA_OPTIONSin archery.Are these changes tested?
To be verified via CI and ursabot.
Are there any user-facing changes?
No