GH-43276: [Go][Parquet] Make DeltaBitPacking Encoders/Decoders Generic#43279
Merged
joellubi merged 9 commits intoapache:mainfrom Jul 17, 2024
Merged
GH-43276: [Go][Parquet] Make DeltaBitPacking Encoders/Decoders Generic#43279joellubi merged 9 commits intoapache:mainfrom
joellubi merged 9 commits intoapache:mainfrom
Conversation
|
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cf9f3db. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes: #43276
The slice of
miniBlockValuesin the decoder was getting reset between calls toDecode, while the remaining internal state of the decoder was persisted. By making the decoder generic, it became possible to bringminiBlockValuesinto the base decoder.The encoder was also made generic for consistency. By avoiding reflection, encoding performance is improved (from around
700 MB/sbefore to about1100 MB/safter on my machine).What changes are included in this PR?
DeltaBinaryPackeddeltaBitPackDecoderanddeltaBitPackEncoderto make them generic.Are these changes tested?
Yes
Are there any user-facing changes?
The DeltaBitPackDecoders should no longer panic when decoding multiple batches from a single page.