ARROW-5113: [C++] Fix DoPut with dictionary arrays, add tests #4319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@wesm @lihalite This makes Flight DoPut work with dictionaries. It shows that |
pitrou
commented
May 15, 2019
pitrou
commented
May 15, 2019
1cc0d1c to
191e008
Compare
ghost
approved these changes
May 20, 2019
Member
Author
|
Thanks @lihalite . Hopefully you don't get too many conflicts on your PRs :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix an error where C++ Flight failed receiving 0-sized batches.