Skip to content

GH-42167: [CI] Upgrade the version of vcpkg in .env#42171

Merged
kou merged 4 commits intoapache:mainfrom
adamreeve:vcpkg_update
Jun 19, 2024
Merged

GH-42167: [CI] Upgrade the version of vcpkg in .env#42171
kou merged 4 commits intoapache:mainfrom
adamreeve:vcpkg_update

Conversation

@adamreeve
Copy link
Copy Markdown
Contributor

@adamreeve adamreeve commented Jun 17, 2024 •
edited by github-actions bot
Loading

Rationale for this change

See #42167

What changes are included in this PR?

  • Upgrades the version of vcpkg in .env to the 2024.04.26 version
    • I didn't use the more recent 2024.05.24 release tag as this fails to build boost libraries due to boost updating the tags of the 1.85.0 release and causing hash mismatches
  • Upgrade the version of CMake installed in the Python Manylinux docker build due to glog requiring 3.22 or higher
  • Rebase the ports.patch file

Are these changes tested?

Yes, this doesn't change behaviour so should be covered by existing tests

Are there any user-facing changes?

No

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 17, 2024

⚠️ GitHub issue #42167 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Jun 17, 2024
@assignUser
Copy link
Copy Markdown
Member

assignUser commented Jun 17, 2024

@github-actions crossbow submit -g vcpkg

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 17, 2024

Revision: 957e1ec

Submitted crossbow builds: ursacomputing/crossbow @ actions-a7e9f6578a

Task Status
test-build-vcpkg-win GitHub Actions

@kou
Copy link
Copy Markdown
Member

kou commented Jun 17, 2024

@github-actions crossbow submit -g wheel java-jars

@assignUser
Copy link
Copy Markdown
Member

assignUser commented Jun 17, 2024

@kou should we add those to the vcpkg group?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 17, 2024

Revision: 957e1ec

Submitted crossbow builds: ursacomputing/crossbow @ actions-f45e57321c

Task Status
java-jars GitHub Actions
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-big-sur-cp311-arm64 GitHub Actions
wheel-macos-big-sur-cp312-arm64 GitHub Actions
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-big-sur-cp39-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions
wheel-macos-catalina-cp311-amd64 GitHub Actions
wheel-macos-catalina-cp312-amd64 GitHub Actions
wheel-macos-catalina-cp38-amd64 GitHub Actions
wheel-macos-catalina-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp38-amd64 GitHub Actions
wheel-manylinux-2-28-cp38-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp38-amd64 GitHub Actions
wheel-manylinux-2014-cp38-arm64 GitHub Actions
wheel-manylinux-2014-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-arm64 GitHub Actions
wheel-windows-cp310-amd64 GitHub Actions
wheel-windows-cp311-amd64 GitHub Actions
wheel-windows-cp312-amd64 GitHub Actions
wheel-windows-cp38-amd64 GitHub Actions
wheel-windows-cp39-amd64 GitHub Actions

@kou
Copy link
Copy Markdown
Member

kou commented Jun 17, 2024

It's a good idea!

@raulcd
Copy link
Copy Markdown
Member

raulcd commented Jun 17, 2024

there seems to be an error on some vcpkg builds to download sqlite3:

[DEBUG] 1000: execute_process(curl --fail -L https://sqlite.org/2024/sqlite-autoconf-3450300.tar.gz --create-dirs --output /Users/runner/work/crossbow/crossbow/vcpkg/downloads/sqlite-autoconf-3450300.zip.86985.part)
[DEBUG] 1000: cmd_execute_and_stream_data() returned 7 after    29593 us
error: Failed to download from mirror set
error: https://sqlite.org/2024/sqlite-autoconf-3450300.tar.gz:

@adamreeve
Copy link
Copy Markdown
Contributor Author

adamreeve commented Jun 17, 2024

there seems to be an error on some vcpkg builds to download sqlite3:

It looks like the sqlite.org server is having issues. Their website is also failing to load for me, although sometimes succeeding. Hopefully it's a temporary issue that will be resolved soon.

@adamreeve
Copy link
Copy Markdown
Contributor Author

adamreeve commented Jun 17, 2024

Looks like the sqlite.org issue should hopefully be resolved now: https://sqlite.org/forum/forumpost/8b1864855e

Can the failing tests be re-run?

@kou
Copy link
Copy Markdown
Member

kou commented Jun 18, 2024

OK! Done!

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jun 18, 2024
Open
kou
kou approved these changes Jun 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit fb368fd into apache:main Jun 19, 2024
@kou kou removed the awaiting review Awaiting review label Jun 19, 2024
@kou kou mentioned this pull request Jun 19, 2024
Closed
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 19, 2024
@llama90 llama90 mentioned this pull request Jun 19, 2024
Closed
@adamreeve adamreeve deleted the vcpkg_update branch June 19, 2024 22:08
@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow bot commented Jun 21, 2024

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit fb368fd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

@raulcd raulcd mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees

No one assigned

Labels

awaiting merge Awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamreeve @assignUser @kou @raulcd