GH-41349: [C#] Optimize DecimalUtility.GetBytes(SqlDecimal) on .NET 7+#42150
Merged
CurtHagenlocher merged 1 commit intoapache:mainfrom Jun 14, 2024
Merged
GH-41349: [C#] Optimize DecimalUtility.GetBytes(SqlDecimal) on .NET 7+#42150CurtHagenlocher merged 1 commit intoapache:mainfrom
CurtHagenlocher merged 1 commit intoapache:mainfrom
Conversation
…ecimal128. Adds a .NET 8 target to Apache.Arrow.csproj to enable the optimization.
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a7a46b2. There were 4 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Adds code to avoid an allocation when converting from SqlDecimal to Decimal128.
Adds a .NET 8 target to Apache.Arrow.csproj to enable the optimization.
Makes a small source change to build successfully with latest C# version.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Closes #41349