GH-40690: [C#][FlightRPC] Add do_exchange csharp implementation#40691
Merged
CurtHagenlocher merged 2 commits intoapache:mainfrom Mar 23, 2024
qmmk:csharp_flight_doexchange
Merged
GH-40690: [C#][FlightRPC] Add do_exchange csharp implementation#40691CurtHagenlocher merged 2 commits intoapache:mainfrom qmmk:csharp_flight_doexchange
CurtHagenlocher merged 2 commits intoapache:mainfrom
qmmk:csharp_flight_doexchange
Conversation
|
|
CurtHagenlocher
approved these changes
Mar 23, 2024
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 6aa6f85. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is a draft implementation of DoExchange. A simple usage demo is in FlightTests.cs and TestFlightServer.cs.
I've tried to share the implementation with DoGet/DoPut as much as possible.
What changes are included in this PR?
Are these changes tested?
Yes, tests are added in FlightTest.cs and TestFlightServer.cs
I've tested locally with the C++ implementation.
Are there any user-facing changes?
No and the DoExchange documentation is already present