Skip to content

GH-40568: [Java] Test failure in Dataset regarding TestAllTypes#40662

Merged
lidavidm merged 1 commit intoapache:mainfrom
vibhatha:gh-40568
Mar 19, 2024
Merged

GH-40568: [Java] Test failure in Dataset regarding TestAllTypes#40662
lidavidm merged 1 commit intoapache:mainfrom
vibhatha:gh-40568

Conversation

@vibhatha
Copy link
Copy Markdown
Contributor

@vibhatha vibhatha commented Mar 19, 2024

Rationale for this change

A recurring CI failure was observed as recorded in #40568.

What changes are included in this PR?

Updating the testing submodule to the changes reflected in apache/arrow-testing#99

Are these changes tested?

Tested by existing test cases.

Are there any user-facing changes?

No

@github-actions
Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@vibhatha
Copy link
Copy Markdown
Contributor Author

@github-actions crossbow submit java

@github-actions github-actions bot added the awaiting review Awaiting review label Mar 19, 2024
@vibhatha vibhatha changed the title [Java] Test failure in Dataset regarding TestAllTypes GH-40568: [Java] Test failure in Dataset regarding TestAllTypes Mar 19, 2024
@github-actions

This comment was marked as outdated.

@kou
Copy link
Copy Markdown
Member

kou commented Mar 19, 2024

@davisusanibar Could you take a look at this?

@vibhatha
Copy link
Copy Markdown
Contributor Author

@github-actions crossbow submit -g java

@github-actions
Copy link
Copy Markdown

Revision: 1b19015

Submitted crossbow builds: ursacomputing/crossbow @ actions-9091e1770d

Task Status
java-jars GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions

@kou
Copy link
Copy Markdown
Member

kou commented Mar 19, 2024

@vibhatha You don't need to submit new jobs for re-run. You can just use the "Re-run jobs" button in the GitHub Actions page: https://github.com/ursacomputing/crossbow/actions/runs/8340911888/job/22827112337

@vibhatha
Copy link
Copy Markdown
Contributor Author

@kou I cannot see a re-run button.

@vibhatha vibhatha marked this pull request as ready for review March 19, 2024 14:59
@kou
Copy link
Copy Markdown
Member

kou commented Mar 19, 2024

@raulcd Could you check whether @vibhatha has a right to re-run jobs or not?

@vibhatha
Copy link
Copy Markdown
Contributor Author

@kou btw seems like CIs are passing.

@davisusanibar
Copy link
Copy Markdown
Contributor

davisusanibar commented Mar 19, 2024 via email

@vibhatha
Copy link
Copy Markdown
Contributor Author

@davisusanibar what do you think about this comment: #40568 (comment)
Am I missing something here?

@vibhatha vibhatha requested review from kou and lidavidm March 19, 2024 15:25
@raulcd
Copy link
Copy Markdown
Member

raulcd commented Mar 19, 2024

@raulcd Could you check whether @vibhatha has a right to re-run jobs or not?

He is not a member of the ursacomputing GitHub organization at the moment. He has the collaborator role on the arrow project which allows to assign issues and trigger crossbow jobs via GitHub comments but cannot re-run jobs on crossbow as far as I understand.

@lidavidm
Copy link
Copy Markdown
Member

@davisusanibar it's because @indigophox reverted it (by accident?) in 2e2bd8b. Sorry, I didn't notice that change at the time. So we can merge this and update the testing submodule properly.

@lidavidm lidavidm merged commit 07e8aa2 into apache:main Mar 19, 2024
@lidavidm lidavidm removed the awaiting review Awaiting review label Mar 19, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Mar 19, 2024
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 07e8aa2.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants