Skip to content

GH-40591: [R] Add extra CSS for navbar on pkgdown website#40610

Merged
amoeba merged 2 commits intoapache:mainfrom
etiennebacher:pkgdown-css
Mar 21, 2024
Merged

GH-40591: [R] Add extra CSS for navbar on pkgdown website#40610
amoeba merged 2 commits intoapache:mainfrom
etiennebacher:pkgdown-css

Conversation

@etiennebacher
Copy link
Copy Markdown
Contributor

@etiennebacher etiennebacher commented Mar 17, 2024

Rationale for this change

This PR fixes #40591. It adds some CSS rules for better readibility of text in the navbar on the pkgdown website.

What changes are included in this PR?

Three new CSS rules, one for each change in the navbar:

  • put the section text (e.g "Get started") in light gray. I chose light gray and not white because white is used when we hover the text;
  • put the version number in light gray
  • put the "Search for" placeholder in light gray

Are these changes tested?

Not applicable

Are there any user-facing changes?

Only visual changes on the website:

  • before:

image

  • after:

image

@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #40591 has been automatically assigned in GitHub to PR creator.

@amoeba
Copy link
Copy Markdown
Member

amoeba commented Mar 18, 2024

Hi @etiennebacher, this looks good to me as-is. Thanks for taking care of it.

Note to reviewers: When looking at this, I wanted to see if we could avoid adding pkgdown's extra.css to make this simpler but it looks like the cosmo theme doesn't provide an appropriate utility class, presumably since it's not designed around a black navbar. There are some in-built utility classes that are close but are either too light or too dark. So I think this is a reasonable approach.

@kou
Copy link
Copy Markdown
Member

kou commented Mar 18, 2024

@github-actions crossbow submit preview-docs

@github-actions
Copy link
Copy Markdown

Revision: 557dc05

Submitted crossbow builds: ursacomputing/crossbow @ actions-25fbe3b09c

Task Status
preview-docs GitHub Actions

@amoeba
Copy link
Copy Markdown
Member

amoeba commented Mar 20, 2024

http://crossbow.voltrondata.com/pr_docs/40610/r/index.html looks good to me. @kou do you agree? I tested locally too.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@amoeba Do you want to merge this as a new committer? :-)

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Mar 20, 2024
@amoeba
Copy link
Copy Markdown
Member

amoeba commented Mar 20, 2024

Sure! And thanks :)

Edit: Though I'll do it tomorrow, with fresh eyes.

@amoeba amoeba merged commit 14027c3 into apache:main Mar 21, 2024
@amoeba amoeba removed the awaiting merge Awaiting merge label Mar 21, 2024
@amoeba
Copy link
Copy Markdown
Member

amoeba commented Mar 21, 2024

Thanks @etiennebacher, we really appreciate you taking the time to contribute this.

@etiennebacher etiennebacher deleted the pkgdown-css branch March 21, 2024 05:50
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 14027c3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs][R] Contrast issues in the navbar on the website

3 participants