GH-40591: [R] Add extra CSS for navbar on pkgdown website#40610
GH-40591: [R] Add extra CSS for navbar on pkgdown website#40610amoeba merged 2 commits intoapache:mainfrom etiennebacher:pkgdown-css
Conversation
|
|
|
Hi @etiennebacher, this looks good to me as-is. Thanks for taking care of it. Note to reviewers: When looking at this, I wanted to see if we could avoid adding pkgdown's extra.css to make this simpler but it looks like the cosmo theme doesn't provide an appropriate utility class, presumably since it's not designed around a black navbar. There are some in-built utility classes that are close but are either too light or too dark. So I think this is a reasonable approach. |
|
@github-actions crossbow submit preview-docs |
|
Revision: 557dc05 Submitted crossbow builds: ursacomputing/crossbow @ actions-25fbe3b09c
|
|
http://crossbow.voltrondata.com/pr_docs/40610/r/index.html looks good to me. @kou do you agree? I tested locally too. |
|
Sure! And thanks :) Edit: Though I'll do it tomorrow, with fresh eyes. |
|
Thanks @etiennebacher, we really appreciate you taking the time to contribute this. |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 14027c3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
This PR fixes #40591. It adds some CSS rules for better readibility of text in the navbar on the
pkgdownwebsite.What changes are included in this PR?
Three new CSS rules, one for each change in the navbar:
Are these changes tested?
Not applicable
Are there any user-facing changes?
Only visual changes on the website: