Skip to content

GH-40441: [GLib][Docs] Use Sphinx for Apache Arrow GLib front page#40442

Merged
kou merged 5 commits intoapache:mainfrom
kou:glib-docs-index
Mar 11, 2024
Merged

GH-40441: [GLib][Docs] Use Sphinx for Apache Arrow GLib front page#40442
kou merged 5 commits intoapache:mainfrom
kou:glib-docs-index

Conversation

@kou
Copy link
Copy Markdown
Member

@kou kou commented Mar 10, 2024

Rationale for this change

Using both of apache/arrow and apache/arrow-site to maintain https://arrow.apache.org/docs/c_glib/ is difficult to maintain.

What changes are included in this PR?

Use https://github.com/apache/arrow/tree/main/docs/source/c_glib as https://arrow.apache.org/docs/c_glib/ 's source.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
Copy link
Copy Markdown
Member Author

kou commented Mar 10, 2024

@github-actions crossbow submit preview-docs

@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #40441 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link
Copy Markdown

Revision: 1d32a42

Submitted crossbow builds: ursacomputing/crossbow @ actions-a989531c52

Task Status
preview-docs GitHub Actions

@kou kou requested review from assignUser and raulcd as code owners March 11, 2024 01:46
@kou
Copy link
Copy Markdown
Member Author

kou commented Mar 11, 2024

@AlenkaF @jorisvandenbossche Can we enable MyST-Parser to use Markdown in Sphinx?

@jorisvandenbossche
Copy link
Copy Markdown
Member

I am certainly fine with that, yes

@AlenkaF
Copy link
Copy Markdown
Member

AlenkaF commented Mar 11, 2024

Me too 👍

@kou
Copy link
Copy Markdown
Member Author

kou commented Mar 11, 2024

Thanks!

I'll merge this.

@kou kou merged commit 1eb46f7 into apache:main Mar 11, 2024
@kou kou deleted the glib-docs-index branch March 11, 2024 08:56
@kou kou removed the awaiting committer review Awaiting committer review label Mar 11, 2024
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1eb46f7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

@kou
Copy link
Copy Markdown
Member Author

kou commented Mar 19, 2024

@github-actions crossbow submit preview-docs

@github-actions
Copy link
Copy Markdown

Revision: 7ab6a3e

Submitted crossbow builds: ursacomputing/crossbow @ actions-20569c1b70

Task Status
preview-docs GitHub Actions

@kou
Copy link
Copy Markdown
Member Author

kou commented Mar 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants