Skip to content

GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests#40381

Merged
pitrou merged 4 commits intoapache:mainfrom
jorisvandenbossche:gh-40379-hypothesis
Mar 7, 2024
Merged

GH-40379: [Python] Fix byte_width for binary(0) + fix hypothesis tests#40381
pitrou merged 4 commits intoapache:mainfrom
jorisvandenbossche:gh-40379-hypothesis

Conversation

@jorisvandenbossche
Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche commented Mar 6, 2024

Rationale for this change

Fixing the hypothesis tests:

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2024

⚠️ GitHub issue #40379 has been automatically assigned in GitHub to PR creator.

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-conda-python-3.11-hypothesis

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2024

Revision: 982866a

Submitted crossbow builds: ursacomputing/crossbow @ actions-fd63f80e3a

Task Status
test-conda-python-3.11-hypothesis GitHub Actions

elif pa.types.is_list_view(ty):
value = _pylist(ty.value_type, size=size, nullable=nullable)
elif pa.types.is_large_list_view(ty):
value = _pylist(ty.value_type, size=size, nullable=nullable)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to create issues to add REE and StringView support as well?

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Mar 7, 2024

@github-actions crossbow submit hypothesis

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2024

Revision: 13eb29f

Submitted crossbow builds: ursacomputing/crossbow @ actions-88ac61f97a

Task Status
test-conda-python-3.11-hypothesis GitHub Actions

@pitrou pitrou merged commit ed5e1b4 into apache:main Mar 7, 2024
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Mar 7, 2024
@jorisvandenbossche jorisvandenbossche deleted the gh-40379-hypothesis branch March 7, 2024 12:36
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit ed5e1b4.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants