Skip to content

GH-20127: [Python][CI] Remove legacy hdfs tests from hdfs and hypothesis setup#40363

Merged
jorisvandenbossche merged 1 commit intoapache:mainfrom
jorisvandenbossche:fix-hdfs-hypothesis
Mar 5, 2024
Merged

GH-20127: [Python][CI] Remove legacy hdfs tests from hdfs and hypothesis setup#40363
jorisvandenbossche merged 1 commit intoapache:mainfrom
jorisvandenbossche:fix-hdfs-hypothesis

Conversation

@jorisvandenbossche
Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche commented Mar 5, 2024 •
edited by github-actions bot
Loading

Rationale for this change

Small follow-up on #39825, which removed the test_hdfs.py file itself, but didn't remove it from the hypothesis script

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

jorisvandenbossche commented Mar 5, 2024

@github-actions crossbow submit test-conda-python-3.11-hypothesis

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Mar 5, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2024

Revision: 6e84caa

Submitted crossbow builds: ursacomputing/crossbow @ actions-3636eb2740

Task Status
test-conda-python-3.11-hypothesis GitHub Actions

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Mar 5, 2024

It would be nice to also fix the HDFS builds themselves (failures seem related?).
https://github.com/ursacomputing/crossbow/actions/runs/8148998591/job/22272924163

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Mar 5, 2024

@github-actions crossbow submit hdfs

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2024

Revision: 6e84caa

Submitted crossbow builds: ursacomputing/crossbow @ actions-4e7114f791

Task Status
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions

@jorisvandenbossche jorisvandenbossche changed the title GH-20127: [Python][CI] Remove legacy hdfs tests from hypothesis setup GH-20127: [Python][CI] Remove legacy hdfs tests from hdfs and hypothesis setup Mar 5, 2024
@jorisvandenbossche
Copy link
Copy Markdown
Member Author

jorisvandenbossche commented Mar 5, 2024

It would be nice to also fix the HDFS builds themselves (failures seem related?).

Ah yes, sorry I should have checked that when merging the PR. But indeed that should be fixed now as well

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

jorisvandenbossche commented Mar 5, 2024

The hypothesis tests are still failing (but now actual test failures instead of erroring on test collection for the missing file). the output is quite incomprehensible though, so not sure what's the issue from a quick look

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

jorisvandenbossche commented Mar 5, 2024

HDFS build is green now!

@jorisvandenbossche jorisvandenbossche merged commit 3d467ac into apache:main Mar 5, 2024
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Mar 5, 2024
@jorisvandenbossche jorisvandenbossche deleted the fix-hdfs-hypothesis branch March 5, 2024 16:13
@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow bot commented Mar 5, 2024

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 3d467ac.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@kou kou Awaiting requested review from kou kou is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

@AlenkaF AlenkaF Awaiting requested review from AlenkaF

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorisvandenbossche @pitrou