Conversation
|
@github-actions crossbow submit -g cpp -g r -g linux -g python -g r |
|
Revision: 1475046 Submitted crossbow builds: ursacomputing/crossbow @ actions-5f343110fe |
|
Failures look all unrelated, so this is good to go. |
|
|
||
| // Glog's severity map. | ||
| static int GetMappedSeverity(ArrowLogLevel severity) { | ||
| static google::LogSeverity GetMappedSeverity(ArrowLogLevel severity) { |
There was a problem hiding this comment.
Does this break compatibility with previous versions? If so, perhaps use auto to be more lenient.
There was a problem hiding this comment.
Ok, I see that previously it was using LogSeverity = int, so nothing should break. Thank you.
|
Thank you. Please note that anything building with ArrowConfig.cmake now fails This was not the case before. Edit: Ah even worse! Even with glog 0.7 being there, providing /usr/lib64/cmake/glog, the build fails because ArrowConfig.cmake can not find uppercas GLOG. |
|
Could you open a new issue for it? |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 5ce060a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Fixes #40181
Are these changes tested?
These changes have been tested as part of the conda feedstocks for Arrow.