Skip to content

GH-39291: [Docs] Remove the "Show source" links from doc pages#40167

Merged
jorisvandenbossche merged 1 commit intoapache:mainfrom
Divyansh200102:Show-source-links-to-404-page
Feb 21, 2024
Merged

GH-39291: [Docs] Remove the "Show source" links from doc pages#40167
jorisvandenbossche merged 1 commit intoapache:mainfrom
Divyansh200102:Show-source-links-to-404-page

Conversation

@Divyansh200102
Copy link
Copy Markdown
Contributor

@Divyansh200102 Divyansh200102 commented Feb 20, 2024

Rationale for this change

To fix the show source button links to 404 page problem

What changes are included in this PR?

The show source button link will be removed.

Are these changes tested?

Not yet

Are there any user-facing changes?

Yes

@github-actions github-actions bot added the awaiting review Awaiting review label Feb 20, 2024
@kou
Copy link
Copy Markdown
Member

kou commented Feb 20, 2024

@github-actions crossbow submit preview-docs

@github-actions
Copy link
Copy Markdown

Revision: da2c098

Submitted crossbow builds: ursacomputing/crossbow @ actions-aa2e029afd

Task Status
preview-docs GitHub Actions

@kou
Copy link
Copy Markdown
Member

kou commented Feb 20, 2024

@kou
Copy link
Copy Markdown
Member

kou commented Feb 21, 2024

The "Show Source" doesn't exist:

@AlenkaF @jorisvandenbossche Can we merge this?

Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Feb 21, 2024
@jorisvandenbossche jorisvandenbossche changed the title GH-39291: [Docs] Fixes Show source links to 404 page GH-39291: [Docs] Remove the "Show source" links from doc pages Feb 21, 2024
@jorisvandenbossche jorisvandenbossche merged commit 6a22a1d into apache:main Feb 21, 2024
@jorisvandenbossche jorisvandenbossche removed the awaiting merge Awaiting merge label Feb 21, 2024
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6a22a1d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] Show source links to 404 page

3 participants