GH-40153: [Python] Update size assumptions for 32-bit platforms#40165
Merged
pitrou merged 1 commit intoapache:mainfrom Feb 21, 2024
Merged
GH-40153: [Python] Update size assumptions for 32-bit platforms#40165pitrou merged 1 commit intoapache:mainfrom
pitrou merged 1 commit intoapache:mainfrom
Conversation
pitrou
reviewed
Feb 20, 2024
pitrou
reviewed
Feb 20, 2024
pitrou
requested changes
Feb 20, 2024
Member
pitrou
left a comment
There was a problem hiding this comment.
LGTM except two nits (see comments)
Update the size assumptions in tests to account for size differences on 32-bit platforms: `pd.object_` is 4 bytes rather than 8 bytes, and `pa.schema` is twice smaller.
pitrou
approved these changes
Feb 20, 2024
Member
|
@github-actions crossbow submit -g python -g wheel |
|
Revision: 50b7d93 Submitted crossbow builds: ursacomputing/crossbow @ actions-d88017a534
|
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1ffed20. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This fixes two tests on 32-bit platforms (tested on x86 specifically).
What changes are included in this PR?
pd.object_size assumption to 4 bytes on 32-bit platformspa.schemasize assumptions to be twice smaller on 32-bit platformsAre these changes tested?
The changes fix tests.
Are there any user-facing changes?
Only test fixes.