GH-38794: [C++][S3] Handle conventional content-type for directories#40147
GH-38794: [C++][S3] Handle conventional content-type for directories#40147pitrou merged 4 commits intoapache:mainfrom
Conversation
|
|
|
@yf-yang This might solve your issue, though obviously I'm not able to test. |
|
Actually, probably not, since the FileInfo result in #38794 (comment) will not be changed. Edit: fixed. |
989c18a to
7fb554c
Compare
|
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
|
@yf-yang Once they are marked "passing", the Crossbow badges above will give you access to binary wheels of PyArrow with this PR's changes (for example : https://github.com/ursacomputing/crossbow/actions/runs/7971839531). Can you try installing the corresponding wheel for your configuration and check if it fixes the issue for you? |
|
Ping @yf-yang |
…ories Some AWS-related tools write and expect the content-type "application/x-directory" for directory-like entries. Unfortunately, this cannot be tested for MinIO, as it apparently ignores the content-type set on directories (as opposed to files).
7fb554c to
70563aa
Compare
|
@github-actions crossbow submit -g wheel -g python |
|
Revision: 70563aa Submitted crossbow builds: ursacomputing/crossbow @ actions-fb005e5ec7
|
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit e38583c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 18 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Some AWS-related tools write and expect the content-type "application/x-directory" for directory-like entries.
This PR does two things:
Are these changes tested?
Unfortunately, this cannot be tested with MinIO, as it seems to ignore the content-type set on directories (as opposed to regular files).
Are there any user-facing changes?
Hopefully better compatibility with existing S3 filesystem hierarchies.