GH-40151: [C++] Make S3 narrative test more flexible#40144
Merged
pitrou merged 2 commits intoapache:mainfrom Feb 20, 2024
Merged
GH-40151: [C++] Make S3 narrative test more flexible#40144pitrou merged 2 commits intoapache:mainfrom
pitrou merged 2 commits intoapache:mainfrom
Conversation
kou
approved these changes
Feb 19, 2024
Member
kou
left a comment
There was a problem hiding this comment.
+1
This is not a MINOR change. Could you open an issue for this?
`arrow-s3fs-narrative-test` allows manual testing of the S3 filesystem implementation against an actual S3 backend such as AWS. This PR allows customizing the endpoint address, and adds a command to create a bucket for testing. Validated with the LocalStack S3 server.
edf158e to
5368e9d
Compare
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4dc3d04. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arrow-s3fs-narrative-testallows manual testing of the S3 filesystem implementation against an actual S3 backend such as AWS.This PR allows customizing the endpoint address, and adds a command to create a bucket for testing.
Validated with the LocalStack S3 server.