GH-40133: [C++][Parquet][Tools] Print FIXED_LEN_BYTE_ARRAY length#40132
Merged
pitrou merged 1 commit intoapache:mainfrom Feb 19, 2024
Merged
GH-40133: [C++][Parquet][Tools] Print FIXED_LEN_BYTE_ARRAY length#40132pitrou merged 1 commit intoapache:mainfrom
pitrou merged 1 commit intoapache:mainfrom
Conversation
In `ParquetFilePrinter`, when printing the type of the column, also print its byte width if the type is FIXED_LEN_BYTE_ARRAY. Before: ``` Column 0: float16_plain (FIXED_LEN_BYTE_ARRAY / Float16) Column 1: float16_byte_stream_split (FIXED_LEN_BYTE_ARRAY / Float16) Column 2: float_plain (FLOAT) Column 3: float_byte_stream_split (FLOAT) Column 4: double_plain (DOUBLE) Column 5: double_byte_stream_split (DOUBLE) Column 6: int32_plain (INT32) Column 7: int32_byte_stream_split (INT32) Column 8: int64_plain (INT64) Column 9: int64_byte_stream_split (INT64) Column 10: flba5_plain (FIXED_LEN_BYTE_ARRAY) Column 11: flba5_byte_stream_split (FIXED_LEN_BYTE_ARRAY) Column 12: decimal_plain (FIXED_LEN_BYTE_ARRAY / Decimal(precision=7, scale=3) / DECIMAL(7,3)) Column 13: decimal_byte_stream_split (FIXED_LEN_BYTE_ARRAY / Decimal(precision=7, scale=3) / DECIMAL(7,3)) ``` After: ``` Column 0: float16_plain (FIXED_LEN_BYTE_ARRAY(2) / Float16) Column 1: float16_byte_stream_split (FIXED_LEN_BYTE_ARRAY(2) / Float16) Column 2: float_plain (FLOAT) Column 3: float_byte_stream_split (FLOAT) Column 4: double_plain (DOUBLE) Column 5: double_byte_stream_split (DOUBLE) Column 6: int32_plain (INT32) Column 7: int32_byte_stream_split (INT32) Column 8: int64_plain (INT64) Column 9: int64_byte_stream_split (INT64) Column 10: flba5_plain (FIXED_LEN_BYTE_ARRAY(5)) Column 11: flba5_byte_stream_split (FIXED_LEN_BYTE_ARRAY(5)) Column 12: decimal_plain (FIXED_LEN_BYTE_ARRAY(4) / Decimal(precision=7, scale=3) / DECIMAL(7,3)) Column 13: decimal_byte_stream_split (FIXED_LEN_BYTE_ARRAY(4) / Decimal(precision=7, scale=3) / DECIMAL(7,3)) ```
|
|
wgtmac
approved these changes
Feb 19, 2024
Member
|
LGTM. having a length for FLBA would be nice. |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2456258. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ParquetFilePrinter, when printing the type of the column, also print its byte width if the type is FIXED_LEN_BYTE_ARRAY.Before:
After: