GH-40095: [C++][Parquet] Remove AVX512 variants of BYTE_STREAM_SPLIT encoding#40127
Merged
pitrou merged 1 commit intoapache:mainfrom Feb 19, 2024
Merged
GH-40095: [C++][Parquet] Remove AVX512 variants of BYTE_STREAM_SPLIT encoding#40127pitrou merged 1 commit intoapache:mainfrom
pitrou merged 1 commit intoapache:mainfrom
Conversation
…SPLIT encoding Two reasons: * the SSE2 and AVX2 variants are already fast enough (on the order of 10 GB/s) * the AVX512 variants do not seem faster, and can even be slower, on tested Intel machines
|
|
cyb70289
approved these changes
Feb 19, 2024
wgtmac
approved these changes
Feb 19, 2024
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit ca67ec2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two reasons:
the SSE2 and AVX2 variants are already fast enough (on the order of 10 GB/s)
the AVX512 variants do not seem faster, and can even be slower, on tested Intel machines
Closes: [C++][Parquet] Remove AVX512 variants of BYTE_STREAM_SPLIT encoding #40095