Skip to content

GH-40023: [Python] Use Cast() instead of CastTo#40116

Merged
AlenkaF merged 4 commits intoapache:mainfrom
llama90:ARROW-40023
Mar 11, 2024
Merged

GH-40023: [Python] Use Cast() instead of CastTo#40116
AlenkaF merged 4 commits intoapache:mainfrom
llama90:ARROW-40023

Conversation

@llama90
Copy link
Copy Markdown
Contributor

@llama90 llama90 commented Feb 18, 2024 •
edited by github-actions bot
Loading

Rationale for this change

Remove legacy code

What changes are included in this PR?

  • Replace the legacy scalar CastTo implementation for Python.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@llama90
Copy link
Copy Markdown
Contributor Author

llama90 commented Feb 24, 2024

@AlenkaF Hello.

If I would like to get this part reviewed, who should I ask? Thank you.

AlenkaF
AlenkaF reviewed Feb 27, 2024
View reviewed changes
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Feb 27, 2024
@AlenkaF
Copy link
Copy Markdown
Member

AlenkaF commented Feb 27, 2024

Added a small comment, otherwise LGTM 👍
I think the CI should be green if you rebase.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Feb 27, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 28, 2024
@llama90
Copy link
Copy Markdown
Contributor Author

llama90 commented Feb 28, 2024 •
edited
Loading

BTW, It didn't work for me with 3.10, so when I configured it to 3.8, it worked.

It is right?

arrow/docs/source/developers/python.rst

Lines 212 to 219 in d6b9051

$ conda create -y -n pyarrow-dev -c conda-forge \
--file arrow/ci/conda_env_unix.txt \
--file arrow/ci/conda_env_cpp.txt \
--file arrow/ci/conda_env_python.txt \
--file arrow/ci/conda_env_gandiva.txt \
compilers \
python=3.10 \
pandas

@llama90
Copy link
Copy Markdown
Contributor Author

llama90 commented Mar 4, 2024

@AlenkaF @jorisvandenbossche

Hello.
Could I request a review to proceed with additional tasks related to this?
Thank you.

AlenkaF
AlenkaF approved these changes Mar 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@llama90
Copy link
Copy Markdown
Contributor Author

llama90 commented Mar 8, 2024

@AlenkaF Hello.

If there are no problems, can you merge it?

@AlenkaF
Copy link
Copy Markdown
Member

AlenkaF commented Mar 8, 2024

@github-actions crossbow submit -g python

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2024

Revision: 159b7ebb461825e3ddef60e9d62bdd3996d2101b

Submitted crossbow builds: ursacomputing/crossbow @ actions-7a0a16d5b4

Task Status
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest GitHub Actions
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0 GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest GitHub Actions
test-cuda-python GitHub Actions
test-debian-11-python-3-amd64 Azure
test-debian-11-python-3-i386 GitHub Actions
test-fedora-39-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 GitHub Actions

@AlenkaF
Copy link
Copy Markdown
Member

AlenkaF commented Mar 8, 2024

@llama90 could you rebase? I think the failures should be gone then =)

@llama90
Copy link
Copy Markdown
Contributor Author

llama90 commented Mar 8, 2024

Oh! I rebased it.

@llama90 llama90 requested a review from AlenkaF March 8, 2024 12:16
@AlenkaF
Copy link
Copy Markdown
Member

AlenkaF commented Mar 8, 2024

@github-actions crossbow submit -g python

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2024

Revision: 40b0711

Submitted crossbow builds: ursacomputing/crossbow @ actions-f68cc7f299

Task Status
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest GitHub Actions
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0 GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest GitHub Actions
test-cuda-python GitHub Actions
test-debian-11-python-3-amd64 Azure
test-debian-11-python-3-i386 GitHub Actions
test-fedora-39-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 GitHub Actions

AlenkaF
AlenkaF approved these changes Mar 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing builds are not connected and have open issues:

Thank you for you contributions @llama90 !

@AlenkaF AlenkaF merged commit b171b26 into apache:main Mar 11, 2024
@AlenkaF AlenkaF removed the awaiting change review Awaiting change review label Mar 11, 2024
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Mar 11, 2024
@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow bot commented Mar 11, 2024

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit b171b26.

There was 1 benchmark result with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlenkaF AlenkaF AlenkaF approved these changes

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

Assignees

No one assigned

Labels

awaiting committer review Awaiting committer review Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python] Remove Scalar legacy cast from Cython test

3 participants

@llama90 @AlenkaF @jorisvandenbossche