GH-40097: [Go][FlightRPC] Enable disabling TLS#40098
Merged
zeroshade merged 2 commits intoapache:mainfrom Feb 20, 2024
Merged
Conversation
|
|
…to the grpcCredentials
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit a690088. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #40097 for more in-depth description
about the problem that led me to file this PR.
Rationale for this change
Because it's annoying to not be able to connect to a non-TLS flightsql endpoint
in my development environment just because my development environment happens
to still use token authentication.
What changes are included in this PR?
Thread the flightsql
DriverConfig.TLSEnabledparameter into thegrpcCredentialstype so thatgrpcCredentials.RequireTransportSecuritycanreturn false if TLS is not enabled on the driver config.
One thing that occurred to me about the
DriverConfig.TLSEnabledfield is thatits semantics seem very mildly dangerous since golang
booltypes arefalseby default and golang doesn't require fields on structs to be explicitly
initialized. It seems to me that
DriverConfig.TLSDisabledwould be better (semantically speaking)because then the API user doesn't have to explicitly enable TLS. But I suppose
it's probably undesirable to change the name of a public field on a public type.
Are these changes tested?
I haven't written any tests, mostly because there weren't already any tests for
the
grpcCredentialstype but I have manually verified this fixes the problemI described in #40097 by rebuilding my
tool and running it against the non-TLS listening thing in my development
environment.
Are there any user-facing changes?
DriverConfig.TLSEnabledfield #40097