Skip to content

GH-30915: [C++][Python] Add missing methods to RecordBatch#39506

Merged
jorisvandenbossche merged 20 commits intoapache:mainfrom
judahrand:main
Mar 15, 2024
Merged

GH-30915: [C++][Python] Add missing methods to RecordBatch#39506
jorisvandenbossche merged 20 commits intoapache:mainfrom
judahrand:main

Conversation

@judahrand
Copy link
Copy Markdown
Contributor

@judahrand judahrand commented Jan 8, 2024 •
edited by github-actions bot
Loading

Rationale for this change

These methods are present on Table but missing on RecordBatch:

  • add_column
  • append_column
  • remove_column
  • set_column
  • drop_columns
  • rename_columns
  • cast

We also should probably accept a dict as input to pa.record_batch like we do for pa.table.

What changes are included in this PR?

Add the methods.

Are these changes tested?

Yes.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2024

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Jan 8, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2024

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@judahrand judahrand force-pushed the main branch 6 times, most recently from 35235a0 to 423a7ad Compare January 10, 2024 08:54
@judahrand judahrand changed the title GH-30915: [Python] Add add/set/remove_column methods to RecordBatch GH-30915: [Python] Add missing methods to RecordBatch Jan 10, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 10, 2024

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@judahrand judahrand force-pushed the main branch 8 times, most recently from d702c6b to e5b0836 Compare January 10, 2024 11:33
@judahrand judahrand mentioned this pull request Jan 10, 2024
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 10, 2024

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@judahrand judahrand changed the title GH-30915: [Python] Add missing methods to RecordBatch GH-30915: [C++][Python] Add missing methods to RecordBatch Jan 10, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 10, 2024

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

2 similar comments
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 10, 2024

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 10, 2024

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2024

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@judahrand
Copy link
Copy Markdown
Contributor Author

judahrand commented Mar 4, 2024

@benibus @jorisvandenbossche I think that I've dealt with all the feedback on this one.

@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Mar 4, 2024
jorisvandenbossche
jorisvandenbossche approved these changes Mar 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the last updates, and for the extensive test parametrization of Recordbatch/Table! Looking all good to me now. Will merge once green

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Mar 15, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 15, 2024

⚠️ GitHub issue #30915 has been automatically assigned in GitHub to PR creator.

@jorisvandenbossche jorisvandenbossche mentioned this pull request Mar 15, 2024
Open
@jorisvandenbossche jorisvandenbossche merged commit 7f361fd into apache:main Mar 15, 2024
@jorisvandenbossche jorisvandenbossche removed the awaiting merge Awaiting merge label Mar 15, 2024
@jorisvandenbossche jorisvandenbossche mentioned this pull request Mar 15, 2024
Closed
@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow bot commented Mar 16, 2024

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 7f361fd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 25 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@benibus benibus Awaiting requested review from benibus

Assignees

No one assigned

Labels

Component: C++ Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python] add_column method missing in pyarrow.RecordBatch

3 participants

@judahrand @jorisvandenbossche @benibus