GH-38768: [Python] Slicing an array backwards beyond the start now includes first item.#39240
Merged
jorisvandenbossche merged 1 commit intoapache:mainfrom Mar 15, 2024
Conversation
Member
|
@jorisvandenbossche Would you be available to review this? |
jorisvandenbossche
approved these changes
Mar 15, 2024
Member
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Sorry for the delayed review, but this looks good to me. Thanks a lot for the contribution!
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 00a4821. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 107 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Minor changes in
_normalize_slicesostartandstopare both computed in a single if/else block instead of having them modified later in case of a negativestep.Are these changes tested?
Yes.
Are there any user-facing changes?
Fixing wrong data returned in an edge case.