Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
|
|
c_glib/test/test-array.rb
Outdated
| def test_diff | ||
| array = build_string_array(["Start", "Shutdown", "Reboot"]) | ||
| other_array = build_string_array(["Start", "Shutdonw", "Reboot"]) | ||
| other_array = build_string_array(["Start", "Shutdown_", "Reboot"]) |
There was a problem hiding this comment.
| other_array = build_string_array(["Start", "Shutdown_", "Reboot"]) | |
| other_array = build_string_array(["Start", "Shutdown", "Reboot"]) |
c_glib/test/test-array.rb
Outdated
| @@ -1, +1 @@ | ||
| -"Shutdown" | ||
| +"Shutdonw" | ||
| +"Shutdown_" |
There was a problem hiding this comment.
| +"Shutdown_" | |
| +"Shutdown" |
There was a problem hiding this comment.
This didn't work. It's doing some sorting to an array. It was my initial correction and tests failed when I did it.
(I know it looks like I'm just fixing things randomly without testing stuff, but I really do try to get CI to pass before I make my initial PRs.)
There was a problem hiding this comment.
I took a look at this test again.
We should not change this because it's a test to detect difference of two arrays. The "Shutdonw" typo is for the difference.
Or we can use other entirely different word something like:
diff --git a/c_glib/test/test-array.rb b/c_glib/test/test-array.rb
index c03aecf17..4da641b20 100644
--- a/c_glib/test/test-array.rb
+++ b/c_glib/test/test-array.rb
@@ -141,12 +141,12 @@ class TestArray < Test::Unit::TestCase
def test_diff
array = build_string_array(["Start", "Shutdown", "Reboot"])
- other_array = build_string_array(["Start", "Shutdonw", "Reboot"])
+ other_array = build_string_array(["Start", "Running", "Reboot"])
assert_equal(<<-STRING.chomp, array.diff_unified(other_array))
@@ -1, +1 @@
-"Shutdown"
-+"Shutdonw"
++"Running"
STRING
end|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 7e286dd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 21 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
What changes are included in this PR?
Spelling fixes to c_glib/
Are these changes tested?
Are there any user-facing changes?