GH-37328: [Python] Add a function to download and extract timezone database on Windows#38179
Merged
jorisvandenbossche merged 16 commits intoapache:mainfrom Mar 20, 2024
Merged
Conversation
|
|
044ce27 to
94033dc
Compare
Member
Author
|
@jorisvandenbossche forgot about this PR a bit. It would be good to have it in 15.0.0 =) |
Member
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Some quick comments!
Member
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Sorry for the slow follow-up here!
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit e52017a. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There is a section in the Arrow C++ documentation with the instructions on how to download and extract text version of the IANA timezone database and on Windows. We should provide a function in PyArrow that a user would call to download and extract the timezone database from Python.
What changes are included in this PR?
Function
download_tzdata_on_windows()added to python/pyarrow/util.py that downloads and extracts timezone database to a standard location in%USERPROFILE%\Downloads\tzdataon Widnows.Are these changes tested?
Yes.
Are there any user-facing changes?
No.