ARROW-2518: [Java] Re-instate JDK tests in matrix, but with JDK 8 instead of JDK 7 #1956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry, my fault. I saw there was OpenJDK8 already there, but missed that it was for integration tests. I should have looked closer. |
BryanCutler
approved these changes
Apr 27, 2018
Member
BryanCutler
left a comment
There was a problem hiding this comment.
LGTM based on a diff. Not sure why Travis is failing, is it unrelated?
Contributor
|
@BryanCutler I think it's unrelated see ARROW-2509. The same thing is happening on 1949 |
Member
|
Great, that's for pointing out the JIRA @paddyhoran , I'll go ahead and commit this since it passed OpenJDK8 tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.