ARROW-2448: [Plasma] Reference counting for PlasmaClient::Impl #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e813b4c to
5f4b196
Compare
pitrou
reviewed
Apr 24, 2018
python/pyarrow/tests/test_plasma.py
Outdated
Member
There was a problem hiding this comment.
You could check buffer contents before this line.
pitrou
reviewed
Apr 24, 2018
python/pyarrow/tests/test_plasma.py
Outdated
Member
There was a problem hiding this comment.
Add a comment explaining what this test checks for?
4523409 to
9d72487
Compare
Member
|
Can you rebase to fix the CI failure? |
9d72487 to
f1e6e8b
Compare
Contributor
Author
|
It's rebased now, the remaining test failure is unrelated I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #1933 which does reference counting of the PlasmaClient held by PlasmaBuffers to avoid the segfault in ARROW-2448.