ARROW-2397: [Documentation] Update format documentation to describe tensor alignment.#1837
ARROW-2397: [Documentation] Update format documentation to describe tensor alignment.#1837robertnishihara wants to merge 2 commits intoapache:masterfrom robertnishihara:fixdoc
Conversation
format/IPC.md
Outdated
| When writing a standalone encapsulated tensor message, we use the format as | ||
| indicated above, but additionally align the starting offset (if writing to a | ||
| shared memory region) to be a multiple of 8: | ||
| indicated above, but additionally align the starting offset of the metadata as well as the starting offset of the tensor body (if writing to a shared |
There was a problem hiding this comment.
Can you wrap the text at the same line width as above?
| shared memory region) to be a multiple of 8: | ||
| indicated above, but additionally align the starting offset of the metadata as | ||
| well as the starting offset of the tensor body (if writing to a shared memory | ||
| region) to be multiples of 64 bytes: |
There was a problem hiding this comment.
Note that this used to be 8 and I replaced it with 64. Please check that this is correct.
There was a problem hiding this comment.
From what we want we want as alignment in the Arrow standard, this is correct. I don't know if all our implementations that emit tensors conform to this.
There was a problem hiding this comment.
I see, I was just looking at
arrow/cpp/src/arrow/ipc/writer.cc
Lines 520 to 528 in 045470c
and
arrow/cpp/src/arrow/ipc/util.h
Lines 31 to 36 in 045470c
|
@xhochy should we merge this? Or should I change the number back to 8? |
|
@robertnishihara I think we can go ahead and merge this. |
No description provided.