ARROW-2225: [JS] support tables split across buffers #1670
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any way to test this? |
Member
|
@wesm I'm working on testing it right now, I can merge when I'm done Edit: If you mean automated tests - we used to have snapshot files that exercised this feature but not anymore after switching over to integration tests |
Member
|
LGTM - Tested locally with an Arrow stream I manually split into a "Schema" and a "Batches" buffer. We should definitely add a test for this, but I'm not sure how to do it right now.. any objections to waiting until we have a JS IPC writer? |
Contributor
Author
|
@TheNeuralBit yeah, that's what I was thinking too. I think we can sit tight since that's now back in progress. |
Member
|
Created ARROW-2235 to track test creation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TheNeuralBit somewhere along the way we lost this. Resolves https://issues.apache.org/jira/browse/ARROW-2225