Skip to content

ARROW-2223: [JS] compile src/bin as es5-cjs to all output targets #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trxcllnt wants to merge 1 commit into from
Closed

ARROW-2223: [JS] compile src/bin as es5-cjs to all output targets #1669

trxcllnt wants to merge 1 commit into from

Conversation

@trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Feb 26, 2018

This ensures the bin files are uniformly es5/commonjs for all target modules. Now this works:

npm i @apache-arrow/esnext-esm
npx arrow2csv -f some-file.arrow

Resolves https://issues.apache.org/jira/browse/ARROW-2223

@TheNeuralBit
Copy link
Member

TheNeuralBit commented Feb 26, 2018

Tested locally with all the umd builds, looks good!

wesm
wesm approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in 1a92846 Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesm wesm wesm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trxcllnt @TheNeuralBit @wesm