ARROW-2094: [C++] Install libprotobuf and set PROTOBUF_HOME when using toolchain #1664
Conversation
Change-Id: I1b901957b362d1d78e1ab8c2658cfcf4964e0e36
| conda create -y -q -p $CPP_TOOLCHAIN python=2.7 \ | ||
| nomkl \ | ||
| boost-cpp \ | ||
| libprotobuf \ |
There was a problem hiding this comment.
Do we also need to install protobuf? Are we assuming that libprotobuf and the protoc called by the orc build step are compatible?
There was a problem hiding this comment.
libprotobuf includes protoc
There was a problem hiding this comment.
I guess we are assuming that orc's protoc and ours are compatible? I could be missing something obvious here.
There was a problem hiding this comment.
The ORC build will just use this one; before this patch we were building protobuf ourselves from source in https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L882
This does upgrade protocol buffers from 2.6.0 to 3.5.1, but I think it's forward compatible (might be wrong). If not we may need to add a protobuf 2.x package to conda-forge
|
Merging. Travis build failure is unrelated |
C++-only libprotobuf is now being provided by conda-forge