ARROW-2215: [Plasma] Hugetables munmap issue#1660
Closed
pcmoritz wants to merge 12 commits intoapache:masterfrom
Closed
ARROW-2215: [Plasma] Hugetables munmap issue#1660pcmoritz wants to merge 12 commits intoapache:masterfrom
pcmoritz wants to merge 12 commits intoapache:masterfrom
Conversation
ac87010 to
43675b1
Compare
xhochy
requested changes
Feb 26, 2018
python/pyarrow/tests/test_plasma.py
Outdated
Member
There was a problem hiding this comment.
Please don't do sudo calls in unit tests. This could rather be a script that is run as an extra step in the CI. Still, this does not seem to test any Arrow/Plasma functionality?
Contributor
There was a problem hiding this comment.
The filesystem created here is used to test Plasma support for huge pages, which is a performance optimization.
Contributor
Author
|
Thanks for the tip about sudo. The test was not complete yet. It is now ready, the test failure is unrelated. |
Contributor
|
Looks good to me. Consider adding a comment in arrow/cpp/src/plasma/malloc.cc Line 158 in e50a8ec |
d988939 to
03da6f0
Compare
Contributor
|
I believe @xhochy's comment is addressed, so I will attempt to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.