Skip to content

ARROW-2214: [JS] add nullBitmap getter to DictionaryData that proxies to its indices' nullBitmap #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trxcllnt wants to merge 1 commit into from
Closed

ARROW-2214: [JS] add nullBitmap getter to DictionaryData that proxies to its indices' nullBitmap #1659

trxcllnt wants to merge 1 commit into from

Conversation

@trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Feb 26, 2018

@trxcllnt trxcllnt mentioned this pull request Feb 26, 2018
Merged
xhochy
xhochy approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@xhochy xhochy closed this in 27d8339 Feb 26, 2018
@trxcllnt trxcllnt deleted the ARROW-2214 branch February 26, 2018 13:18
@nmichaud
Copy link

nmichaud commented Feb 26, 2018

Was this actually merged?

@xhochy
Copy link
Member

xhochy commented Feb 26, 2018

@nmichaud yes this is merged as a squashed commit in 27d8339 As there was no merge commit, this does look different in the GitHub UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhochy xhochy xhochy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trxcllnt @nmichaud @xhochy