ARROW-2184: [C++] Add static constructor for FileOutputStream returning shared_ptr to OutputStream #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Just rebased this, please |
xhochy
approved these changes
Feb 22, 2018
Member
xhochy
left a comment
There was a problem hiding this comment.
+1, LGTM.
I would like to keep the more specific ones as they are nice to have if you work in a more strongly typed, pure C++ environment.
wesm
reviewed
Feb 22, 2018
| /// \param[in] append append to existing file, otherwise truncate to 0 bytes | ||
| /// \param[out] out a base interface OutputStream instance | ||
| static Status Open(const std::string& path, bool append, | ||
| std::shared_ptr<OutputStream>* out); |
Member
There was a problem hiding this comment.
We need some unit tests for these. We should also change the Python bindings to use these APIs
Contributor
Author
There was a problem hiding this comment.
Do we need to change the Python bindings in this pull request?
Member
There was a problem hiding this comment.
I pushed a commit here to make the change, so we're good now
Change-Id: I4fe462e126292de1a954ca735cb2aaf02ead0e53
Member
|
+1. Will merge once the build is green. Thanks! |
xhochy
approved these changes
Feb 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constructors to return pointers to the base interface