Skip to content

ARROW-18290: [C++] Escape all special chars in URI-encoding#14645

Merged
pitrou merged 1 commit intoapache:masterfrom
pitrou:ARROW-18290-aws-escape-chars
Nov 15, 2022
Merged

ARROW-18290: [C++] Escape all special chars in URI-encoding#14645
pitrou merged 1 commit intoapache:masterfrom
pitrou:ARROW-18290-aws-escape-chars

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented Nov 15, 2022

By default, the AWS SDK doesn't URI-escape some special chars such as '='. This works fine with AWS endpoints, but not with some non-AWS S3-compatible endpoints.

By default, the AWS SDK doesn't URI-escape some special chars such as '='.
This works fine with AWS endpoints, but not with some non-AWS S3-compatible endpoints.
@github-actions
Copy link
Copy Markdown

@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Nov 15, 2022

@milesgranger I don't know if you would be able to test this. The fix requires a recent enough AWS SDK.

@github-actions
Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Copy Markdown
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. 👍 (testing with 1.10.7 SDK)

Edit: Also, thank you! :)

@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Nov 15, 2022

Great, thank you! Will merge then.

@pitrou pitrou merged commit a068096 into apache:master Nov 15, 2022
@pitrou pitrou deleted the ARROW-18290-aws-escape-chars branch November 15, 2022 16:07
@ursabot
Copy link
Copy Markdown

ursabot commented Nov 15, 2022

Benchmark runs are scheduled for baseline = dc7f1ee and contender = a068096. a068096 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.14% ⬆️0.34%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️2.12% ⬆️0.18%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] a068096d ec2-t3-xlarge-us-east-2
[Finished] a068096d test-mac-arm
[Finished] a068096d ursa-i9-9960x
[Finished] a068096d ursa-thinkcentre-m75q
[Finished] dc7f1ee2 ec2-t3-xlarge-us-east-2
[Finished] dc7f1ee2 test-mac-arm
[Finished] dc7f1ee2 ursa-i9-9960x
[Finished] dc7f1ee2 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants