Skip to content

ARROW-16659: [C++] Remove ambiguous constructor for VectorKernel #13235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zagto wants to merge 1 commit into from
Closed

ARROW-16659: [C++] Remove ambiguous constructor for VectorKernel #13235

zagto wants to merge 1 commit into from
+0 −3

Conversation

@zagto
Copy link
Contributor

@zagto zagto commented May 25, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented May 25, 2022

https://issues.apache.org/jira/browse/ARROW-16659

westonpace
westonpace approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@ursabot
Copy link

ursabot commented May 26, 2022

Benchmark runs are scheduled for baseline = 5c02620 and contender = cf414db. cf414db is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.9% ⬆️0.23%] test-mac-arm
[Failed ⬇️0.36% ⬆️0.71%] ursa-i9-9960x
[Finished ⬇️0.16% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] cf414db7 ec2-t3-xlarge-us-east-2
[Finished] cf414db7 test-mac-arm
[Finished] cf414db7 ursa-i9-9960x
[Finished] cf414db7 ursa-thinkcentre-m75q
[Finished] 5c02620a ec2-t3-xlarge-us-east-2
[Failed] 5c02620a test-mac-arm
[Failed] 5c02620a ursa-i9-9960x
[Finished] 5c02620a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonpace westonpace westonpace approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zagto @ursabot @westonpace