Skip to content

ARROW-16647: [C++] Add support for unique(), value_counts(), dictionary_encode() with interval types #13231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
okadakk wants to merge 1 commit into from
Closed

ARROW-16647: [C++] Add support for unique(), value_counts(), dictionary_encode() with interval types #13231

okadakk wants to merge 1 commit into from
+54 −0

Conversation

@okadakk
Copy link
Contributor

@okadakk okadakk commented May 25, 2022 •
edited
Loading

Add support for unique(), value_counts(), dictionary_encode() with interval types.

@okadakk okadakk changed the title [ARROW-16647][C++] Add support for unique(), value_counts(), dictionary_encode() with interval types ARROW-16647: [C++] Add support for unique(), value_counts(), dictionary_encode() with interval types May 25, 2022
@github-actions
Copy link

github-actions bot commented May 25, 2022

https://issues.apache.org/jira/browse/ARROW-16647

@github-actions
Copy link

github-actions bot commented May 25, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

lidavidm
lidavidm approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lidavidm lidavidm closed this in 05a82b6 May 25, 2022
@ursabot
Copy link

ursabot commented May 26, 2022

Benchmark runs are scheduled for baseline = f766159 and contender = 05a82b6. 05a82b6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.27% ⬆️0.04%] test-mac-arm
[Failed ⬇️4.41% ⬆️0.74%] ursa-i9-9960x
[Finished ⬇️1.54% ⬆️0.08%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 05a82b67 ec2-t3-xlarge-us-east-2
[Failed] 05a82b67 test-mac-arm
[Failed] 05a82b67 ursa-i9-9960x
[Finished] 05a82b67 ursa-thinkcentre-m75q
[Finished] f7661597 ec2-t3-xlarge-us-east-2
[Failed] f7661597 test-mac-arm
[Failed] f7661597 ursa-i9-9960x
[Finished] f7661597 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 26, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@okadakk @ursabot @lidavidm