Skip to content

Conversation

@Johnnathanalmeida
Copy link
Contributor

This PR was created to implement binary functions in Gandiva side based on Hive implementation.

This PR implements the follow signatures:

FunctionSignature{name =binary, return type =binary, param types =[string]}
FunctionSignature{name =binary, return type =binary, param types =[binary]}

@github-actions
Copy link

github-actions bot commented May 5, 2022

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@Johnnathanalmeida
Copy link
Contributor Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

github-actions bot commented May 5, 2022

Revision: 7dbbda569f6e40c8f7df0d773ca5945ee96fb442

Submitted crossbow builds: ursacomputing/crossbow @ actions-2019

Task Status
java-jars Github Actions

@Johnnathanalmeida Johnnathanalmeida force-pushed the feature/add-binary-function branch from 7dbbda5 to 6c082da Compare May 11, 2022 11:28
@Johnnathanalmeida Johnnathanalmeida changed the title [Gandiva][C++] Add binary functions ARROW-16527: [Gandiva][C++] Add binary functions May 11, 2022
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@Johnnathanalmeida Johnnathanalmeida force-pushed the feature/add-binary-function branch from 6324122 to 600cff1 Compare May 12, 2022 11:32
@Johnnathanalmeida
Copy link
Contributor Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 600cff15d67df015c8508867a9e65ee6772201cf

Submitted crossbow builds: ursacomputing/crossbow @ actions-2076

Task Status
java-jars Github Actions

@Johnnathanalmeida Johnnathanalmeida force-pushed the feature/add-binary-function branch from 600cff1 to 03b4105 Compare May 23, 2022 11:40
@Johnnathanalmeida Johnnathanalmeida force-pushed the feature/add-binary-function branch from b3ec841 to 9b61295 Compare May 24, 2022 11:57
@pravindra pravindra closed this in f766159 May 25, 2022
@ursabot
Copy link

ursabot commented May 25, 2022

Benchmark runs are scheduled for baseline = 3b92f02 and contender = f766159. f766159 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.16% ⬆️0.08%] test-mac-arm
[Failed ⬇️0.37% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.24% ⬆️0.2%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f7661597 ec2-t3-xlarge-us-east-2
[Failed] f7661597 test-mac-arm
[Failed] f7661597 ursa-i9-9960x
[Finished] f7661597 ursa-thinkcentre-m75q
[Finished] 3b92f027 ec2-t3-xlarge-us-east-2
[Failed] 3b92f027 test-mac-arm
[Failed] 3b92f027 ursa-i9-9960x
[Finished] 3b92f027 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants