ARROW-16255: [R] Reorganise the datetime bindings #13029
Conversation
… `test-dplyr-funcs-datetime.R`
…atetime.R` and re-structured the registering functions
thisisnic
left a comment
There was a problem hiding this comment.
This is great - thanks very much for re-organising these, will make it a lot easier for newer contributors to find their way around the project.
|
Benchmark runs are scheduled for baseline = 7f6b074 and contender = 893faa7. 893faa7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
The purpose of this PR is to reorganise the datetime bindings.
Why?
R/dplyr-funcs-type.R)register_bindings_...()functions are too complex and trigger the cyclocomp lintWhat?
R/dplyr-datetime-helpers.Rdplyr-funcs-datetime.R(with the exception ofleap_year, which was moved toexpressions.R)test-dplyr-funcs-datetime.RResults
dplyr-funcs-datetime.Rreduced to 21 (from 26)More details
strptimeregister_bindings_datetime()register_bindings_datetime_utility()strftimeregister_bindings_datetime()register_bindings_datetime_utility()format_ISO8601register_bindings_datetime()register_bindings_datetime_utility()secondregister_bindings_datetime()register_bindings_datetime_components()wdayregister_bindings_datetime()register_bindings_datetime_components()weekregister_bindings_datetime()register_bindings_datetime_components()monthregister_bindings_datetime()register_bindings_datetime_components()is.Dateregister_bindings_datetime()register_bindings_datetime_utility()is.instantregister_bindings_datetime()register_bindings_datetime_utility()is.timepointregister_bindings_datetime()register_bindings_datetime_utility()is.POSIXctregister_bindings_datetime()register_bindings_datetime_utility()leap_yearregister_bindings_datetime()amregister_bindings_datetime()register_bindings_datetime_components()pmregister_bindings_datetime()register_bindings_datetime_components()tzregister_bindings_datetime()register_bindings_datetime_components()semesterregister_bindings_datetime()register_bindings_datetime_components()dateregister_bindings_datetime()register_bindings_datetime_utility()make_datetimeregister_bindings_duration()register_bindings_datetime_conversion()make_dateregister_bindings_duration()register_bindings_datetime_conversion()ISOdatetimeregister_bindings_duration()register_bindings_datetime_conversion()ISOdateregister_bindings_duration()register_bindings_datetime_conversion()difftimeregister_bindings_duration()register_bindings_duration()as.difftimeregister_bindings_duration()register_bindings_duration()decimal_dateregister_bindings_duration()register_bindings_datetime_conversion()date_decimalregister_bindings_duration()register_bindings_datetime_conversion()duration_helpers_map_factoryregister_bindings_duration_helpers()register_bindings_duration_helpers()dpicosecondsregister_bindings_duration_helpers()register_bindings_duration_helpers()make_difftimeregister_bindings_difftime_constructors()register_bindings_duration_constructor()as.Dateregister_bindings_type_cast()register_bindings_datetime_conversion()as_dateregister_bindings_type_cast()register_bindings_datetime_conversion()as_datetimeregister_bindings_type_cast()register_bindings_datetime_conversion()