Skip to content

ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset #12952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlenkaF wants to merge 5 commits into from
Closed

ARROW-16121: [Python] Deprecate the (common_)metadata(_path) attributes of ParquetDataset #12952

AlenkaF wants to merge 5 commits into from

Conversation

@AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Apr 22, 2022

This PR tries to:

  • deprecate the metadata, metadata_path and common_metadata_path attributes in the legacy ParquetDataset.
  • deprecate passing the metadata keyword in the ParquetDataset constructor.

common_metadata attribute has already been deprecated.

@github-actions
Copy link

github-actions bot commented Apr 22, 2022

https://issues.apache.org/jira/browse/ARROW-16121

AlenkaF
AlenkaF commented Apr 22, 2022
View reviewed changes
jorisvandenbossche
jorisvandenbossche reviewed Apr 22, 2022
View reviewed changes
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Apr 22, 2022

There is a test_parquet_dataset_deprecated_properties test where you can add the new deprecated ones

@kszucs kszucs closed this in a16be6b Apr 22, 2022
@AlenkaF AlenkaF deleted the ARROW-16121 branch April 23, 2022 09:53
@ursabot
Copy link

ursabot commented Apr 26, 2022

Benchmark runs are scheduled for baseline = f23965c and contender = a16be6b. a16be6b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.08% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/594| a16be6b7 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/582| a16be6b7 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/581| a16be6b7 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/592| a16be6b7 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/593| f23965ce ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/581| f23965ce test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/579| f23965ce ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/591| f23965ce ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlenkaF @jorisvandenbossche @ursabot