-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-16204: [C++][Dataset] Default error existing_data_behaviour for writing dataset ignores a single file #12898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… writing dataset ignores a single file
|
|
| pa.schema([("c", pa.int16())]), flavor="hive" | ||
| ) | ||
| ds.write_dataset(table, "sample_dataset", format="parquet", partitioning=part) | ||
| ds.write_dataset(table, "partitioned_dataset", format="parquet", partitioning=part) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already wrote to "sample_dataset" a bit above, so this now started to (correctly) raise an error if using the same name
|
@westonpace I think it should be a trivial bug fix, but it would be good to get a sanity check |
westonpace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thank you. I think I was allowing the base dir to exist but the docs are pretty clear that the base dir is not returned by GetFileInfo(selector).
|
Benchmark runs are scheduled for baseline = 16638a4 and contender = 912e2bb. 912e2bb is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.