ARROW-11259: [Python] Allow to create field reference to nested field #12863
Conversation
|
|
lidavidm
left a comment
There was a problem hiding this comment.
LGTM, thank you! I left a couple thoughts.
There was a problem hiding this comment.
Do we have to spell out field_ref(FieldRef("foo", "bar")) explicitly or is it possible to simply write field_ref("foo", "bar")?
There was a problem hiding this comment.
Currently it doesn't work, FieldRef("foo", "bar") needs to be spelled out.
Try 1: `field_ref("foo", "bar")`
```
/Users/alenkafrim/repos/arrow/cpp/src/arrow/compute/exec/expression_test.cc:1379:20: error: no matching function for call to 'field_ref'
ExpectRoundTrips(field_ref("foo", "bar", "baz"));
^~~~~~~~~
/Users/alenkafrim/repos/arrow/cpp/src/arrow/compute/exec/expression.h:152:12: note: candidate function not viable: requires single argument 'ref', but 3 arguments were provided
Expression field_ref(FieldRef ref);
```
Try 2: `field_ref(("foo", "bar"))`
```
/Users/alenkafrim/repos/arrow/cpp/src/arrow/compute/exec/expression_test.cc:1379:31: warning: expression result unused [-Wunused-value]
ExpectRoundTrips(field_ref(("foo", "bar", "baz")));
```
|
Benchmark runs are scheduled for baseline = 83dda5c and contender = e0668e2. e0668e2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR tries to redo the work from #9799.
It will unblock:
cc @jorisvandenbossche @pitrou