Skip to content

Conversation

@djnavarro
Copy link
Contributor

updates the binding for lubridate::leap_year to call is_leap_year directly now that it is available

@github-actions
Copy link

@rok
Copy link
Member

rok commented Mar 10, 2022

LGTM

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@thisisnic thisisnic closed this in 6aa8daa Mar 14, 2022
@ursabot
Copy link

ursabot commented Mar 14, 2022

Benchmark runs are scheduled for baseline = fa4e9b2 and contender = 6aa8daa. 6aa8daa is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.59% ⬆️0.25%] test-mac-arm
[Finished ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.49% ⬆️0.13%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants