ARROW-15871: [Python] Start raising deprecation warnings for ParquetDataset keywords that won't be supported with the new API#12585
Conversation
|
@github-actions crossbow submit -g integration |
|
Revision: 0001bf47ac4b5916234eae79f689eaa5f10de889 Submitted crossbow builds: ursacomputing/crossbow @ actions-1729
|
python/pyarrow/parquet.py
Outdated
There was a problem hiding this comment.
| "Specifying the 'metadata_nthreads' keyword is deprecated as " | |
| "of pyarrow 8.0.0, and the keyword will be removed in a " | |
| "future version", | |
| "Specifying the 'metadata_nthreads' argument is deprecated as " | |
| "of pyarrow 8.0.0, and the keyword will be argument in a " | |
| "future version", |
There was a problem hiding this comment.
(may need reformatting after this change?)
python/pyarrow/parquet.py
Outdated
There was a problem hiding this comment.
Here as well, say "argument" not "keyword".
0001bf4 to
2b5345e
Compare
… it in the non-legacy read_table
|
I forgot about this PR. I rebased and will merge if green. |
|
@github-actions crossbow submit -g integration |
|
Revision: 6ebd216 Submitted crossbow builds: ursacomputing/crossbow @ actions-1805
|
|
Benchmark runs are scheduled for baseline = ba04e7f and contender = ea4ab77. ea4ab77 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Added warnings for when passing the
schemaandmetadata_nthreadskeywords.For
schema, also enabled this keyword for the new implementation (passing through theschemakeyword to the datasets API), but so in this case this is about a pyarrow.Schema and not a ParquetSchema that should be passed.