Skip to content

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Feb 23, 2022

This is intended to support ARROW-15706 and ARROW-15282. This splits out tests which do not touch the transport into their own test. Meanwhile, data plane methods are moved into a common library and can be instantiated for specific transports. This also does some cleanup to remove some redundant test helpers, and removes a DISABLED test that was effectively never being run.

@github-actions
Copy link

@apache apache deleted a comment from github-actions bot Feb 23, 2022
@lidavidm lidavidm changed the title ARROW-15707: [C++][FlightRPC] Split out Flight tests that don't use the network ARROW-15707: [C++][FlightRPC] Make Flight tests resuable across transports Feb 24, 2022
@lidavidm lidavidm changed the title ARROW-15707: [C++][FlightRPC] Make Flight tests resuable across transports ARROW-15707: [C++][FlightRPC] Make Flight tests more resuable across transports Feb 24, 2022
@lidavidm lidavidm force-pushed the arrow-15707 branch 2 times, most recently from 1ce9a0d to 4eb00c6 Compare February 25, 2022 15:27
Copy link
Contributor

@cyb70289 cyb70289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested okay, +1

@cyb70289 cyb70289 closed this in 781c478 Mar 1, 2022
@ursabot
Copy link

ursabot commented Mar 1, 2022

Benchmark runs are scheduled for baseline = 6907398 and contender = 781c478. 781c478 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.38% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.34% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants