ARROW-14094: [C++] add(timestamp, duration) -> timestamp kernel #12378
Conversation
There was a problem hiding this comment.
TimestampType and DurationType are both int64_t underneath, is it possible to reuse the existing Exec method? (i.e. does ArithmeticExecFromOp<ScalarBinary, Add>(Type::INT64) work here?)
There was a problem hiding this comment.
It works for ScalarBinaryEqualTypes but not for ScalarBinary as it takes in and out types.
auto exec = ArithmeticExecFromOp<ScalarBinaryEqualTypes, Add>(Type:: INT64); would work.
We could add ArithmeticExecFromOpEqualTypes.
There was a problem hiding this comment.
Ah, I think it's not too big a deal then.
|
Benchmark runs are scheduled for baseline = ec3608c and contender = e31189f. e31189f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This is to resolve ARROW-14094.