Skip to content

ARROW-14823: [R] Implement bindings for lubridate::leap_year #12173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
djnavarro wants to merge 2 commits into from
Closed

ARROW-14823: [R] Implement bindings for lubridate::leap_year #12173

djnavarro wants to merge 2 commits into from

Conversation

@djnavarro
Copy link
Contributor

@djnavarro djnavarro commented Jan 18, 2022

Does what it says in the title: adds binding for lubridate::leap_year

@github-actions
Copy link

github-actions bot commented Jan 18, 2022

https://issues.apache.org/jira/browse/ARROW-14823

@github-actions
Copy link

github-actions bot commented Jan 18, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

thisisnic
thisisnic approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - does everything it needs to and is implemented identically to the lubridate equivalent. Thanks for this! I'll approve it now, and merge once the builds have all passed.

@djnavarro
Copy link
Contributor Author

djnavarro commented Jan 18, 2022

Yay! Nice to have an easy one this time 😀

@thisisnic thisisnic closed this in 1fc9a29 Jan 18, 2022
@ursabot
Copy link

ursabot commented Jan 18, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = 2a221e1 and contender = 1fc9a29. 1fc9a29 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thisisnic thisisnic thisisnic approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djnavarro @ursabot @thisisnic