ARROW-14100: [C++] subtract(duration, duration) -> duration kernel #12141
Conversation
There was a problem hiding this comment.
Add tests with valid values.
There was a problem hiding this comment.
Do you mean like these?
I'd like to enable cases like subtract(duration[ms], duration[us]) -> duration[us]. I'll ping when it's done.
There was a problem hiding this comment.
Ok, this now covers cases like subtract(duration[ms], duration[us]) -> duration[us].
b6ce245 to
9526cf6
Compare
|
Sorry for the push. Had to rebase. |
|
Ha, there are conflicts again :-) |
It's the overhead price of distributed review chunks :) |
There was a problem hiding this comment.
Can you add tests for overflowing inputs?
There was a problem hiding this comment.
Added. However it seems as it duration is not treated as int64_t here and overflow is not detected?
There was a problem hiding this comment.
Never mind. I was using the wrong operator.
a68f285 to
f2c4b16
Compare
pitrou
left a comment
There was a problem hiding this comment.
+1, thank you. I'll just wait for the AppVeyor build to run again.
|
Thanks for the review @pitrou. The appveyor issue seems related to the substrait parser. Maybe a rebase will help. |
|
Benchmark runs are scheduled for baseline = 1b9e76c and contender = d97640c. d97640c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
ARROW-14100