Skip to content

ARROW-14924: [C++] generic fs tests for GcsFileSystem #12127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
coryan wants to merge 1 commit into from
Closed

ARROW-14924: [C++] generic fs tests for GcsFileSystem #12127

coryan wants to merge 1 commit into from

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Jan 11, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 11, 2022

https://issues.apache.org/jira/browse/ARROW-14924

@coryan coryan marked this pull request as ready for review January 11, 2022 18:40
@coryan
Copy link
Contributor Author

coryan commented Jan 13, 2022

@pitrou or @emkornfield, could you take a look?

pitrou
pitrou approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I'm glad that no further adaptations were required. Thank you very much for this.

@pitrou pitrou closed this in 30ddc2f Jan 18, 2022
@ursabot
Copy link

ursabot commented Jan 18, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = 0174d39 and contender = 30ddc2f. 30ddc2f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.04% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@asfimport asfimport mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coryan @ursabot @pitrou