Skip to content

ARROW-15266: [R] [CI] Test reorganization triggering valgrind errors#12090

Closed
paleolimbot wants to merge 1 commit intoapache:masterfrom
paleolimbot:r-tests-re
Closed

ARROW-15266: [R] [CI] Test reorganization triggering valgrind errors#12090
paleolimbot wants to merge 1 commit intoapache:masterfrom
paleolimbot:r-tests-re

Conversation

@paleolimbot
Copy link
Copy Markdown
Member

@paleolimbot paleolimbot commented Jan 6, 2022

This PR is to fix a valgrind failure that started occurring after #11904 (ARROW-15010) was merged.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2022

https://issues.apache.org/jira/browse/ARROW-15266

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@paleolimbot
Copy link
Copy Markdown
Member Author

paleolimbot commented Jan 6, 2022

@github-actions crossbow submit test-r-linux-valgrind

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2022

Revision: 2488ad7

Submitted crossbow builds: ursacomputing/crossbow @ actions-1377

Task Status
test-r-linux-valgrind Azure

jonkeane
jonkeane approved these changes Jan 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It's also nice that the re2-skip is now much more limited for these tests (IIRC, strptime and strftime both were gated before, but aren't now)

@jonkeane jonkeane closed this in 6683255 Jan 7, 2022
@ursabot
Copy link
Copy Markdown

ursabot commented Jan 7, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = f054440 and contender = 6683255. 6683255 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@paleolimbot paleolimbot deleted the r-tests-re branch January 20, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonkeane jonkeane jonkeane approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paleolimbot @ursabot @jonkeane